Fixed unset mainpage in Creator

openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python

https://pypi.org/project/libzim/

GNU General Public License v3.0

62 stars 20 forks source link

Fixed unset mainpage in Creator #43

Closed rgaudin closed 4 years ago

rgaudin commented 4 years ago

Fixed #36 by fixing the OverriddenZimCreator::getMainUrl signature.

kelson42 commented 4 years ago

@rgaudin CI is failing, you know why?

rgaudin commented 4 years ago

No, it's been failing since https://github.com/openzim/python-libzim/runs/753243874?check_suite_focus=true but I doub't removing this print() was the cause.

mgautierfr commented 4 years ago

The CI was using a old version of libzim. New version fix a race condition when we delete the creator just after ("to soon") we call the finalize method.

We last version of libzim CI is ok.