Closed rgaudin closed 4 years ago
I am unable to reproduce the failing test, neither on macOS (py38, py36) nor on docker/linux (python:3.8
). I'm short of explanation for this…
The final code is good. But 7 commits for this is a bit too much :) And please, rebase on
master
instead of mergingmaster
into the branch.
Yes, the Resolve Conflict button on github is a curse :) Kept the tests in a separate commit though.
We are good.
Fixes #41 by explicitly deleting the creatorWrapper once we've finalized it on the
Creator.close
.Also fixes #31 by calling
close()
onCreator
(pure-python) deletion