Properly dealloc creatorWrapper on close

openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python

https://pypi.org/project/libzim/

GNU General Public License v3.0

62 stars 20 forks source link

Closed rgaudin closed 4 years ago

rgaudin commented 4 years ago

Fixes #41 by explicitly deleting the creatorWrapper once we've finalized it on the Creator.close.

Also fixes #31 by calling close() on Creator (pure-python) deletion

rgaudin commented 4 years ago

I am unable to reproduce the failing test, neither on macOS (py38, py36) nor on docker/linux (python:3.8). I'm short of explanation for this…

rgaudin commented 4 years ago

The final code is good. But 7 commits for this is a bit too much :) And please, rebase on master instead of merging master into the branch.

Yes, the Resolve Conflict button on github is a curse :) Kept the tests in a separate commit though.

mgautierfr commented 4 years ago

We are good.