openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python
https://pypi.org/project/libzim/
GNU General Public License v3.0
62 stars 20 forks source link

Require get_size() implementation by user #78

Closed rgaudin closed 4 years ago

rgaudin commented 4 years ago

getSize being implemented in the wrapper, and its implementation relying on returning the size of get_data(), it prevented the use of get_filename (allowed by libzim).

This now requires user to implement get_size(), not making any assumption about it.

codecov[bot] commented 4 years ago

Codecov Report

Merging #78 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           99       103    +4     
=========================================
+ Hits            99       103    +4     
Impacted Files Coverage Δ
libzim/writer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaf3d6b...c32525e. Read the comment docs.

rgaudin commented 4 years ago

rebased