search

openzim / python-libzim

Libzim binding for Python: read/write ZIM files in Python
https://pypi.org/project/libzim/
GNU General Public License v3.0
62 stars 19 forks source link

Fail early if cant write to destination #98

Closed rgaudin closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #98 (4e3f8d3) into master (cedfbd7) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   96.29%   96.34%   +0.04%     
==========================================
  Files           3        3              
  Lines         297      301       +4     
==========================================
+ Hits          286      290       +4     
  Misses         11       11
Impacted Files Coverage Δ
libzim/wrapper.pyx 95.15% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cedfbd7...4e3f8d3. Read the comment docs.

mgautierfr commented 3 years ago

Nothing to say on the code. But I wonder if we need to move this on libzim side instead/also.

rgaudin commented 3 years ago

But I wonder if we need to move this on libzim side instead/also.

Agrees it's useful for all libzim users so might be a better fit at libzim. We can keep it in the wrapper until that gets implemented in libzim though.

mgautierfr commented 3 years ago

Yes, we will remove it later.