openzipkin-attic / zipkin-azure

Reporters and collectors for use in Azure
Apache License 2.0
11 stars 9 forks source link

LazyRegisterEventProcessor is not actually an event processor #12

Closed aliostad closed 7 years ago

aliostad commented 7 years ago

LazyRegisterEventProcessor is actually an LazyRegisterEventProcessorHost. There is a big difference between the host and processor. I suggest renaming. to LazyRegisterEventProcessorHost.

codefromthecrypt commented 7 years ago

"lazy register eventprocessor" is indeed an abbreviation for "lazy register eventprocessor with host". Is there something else that you'd expect the eventprocessor to be lazily registered with, where appending host resolves that ambiguity?

codefromthecrypt commented 7 years ago

either way I don't care on this one. will rename to append host

codefromthecrypt commented 7 years ago

here you go. https://github.com/openzipkin/zipkin-azure/pull/15

aliostad commented 7 years ago

Thank you