search

openzipkin-attic / zipkin-azure

Reporters and collectors for use in Azure
Apache License 2.0
11 stars 9 forks source link

Fixes checkpoint logic and backfills concurrency tests #17

Closed codefromthecrypt closed 7 years ago

codefromthecrypt commented 7 years ago

This fixes the checkpoint logic, and backfills tests. Since we currently don't know if callbacks are always on a different thread, this assumes they will be. If someone from microsoft can confirm that callbacks are always on the same thread, we can remove a lot of defense.

Fixes #16

codefromthecrypt commented 7 years ago

@aliostad I'm merging this to fix the bug. I've also opened https://github.com/Azure/azure-event-hubs-java/issues/52 on this topic. If later, we can be less defensive, any of us will gladly prune back the concurrency and special-casing of how the underlying code is accessed.