search

openzipkin-attic / zipkin-azure

Reporters and collectors for use in Azure
Apache License 2.0
11 stars 9 forks source link

added single quotes for powershell compatibility #21

Closed praveenbarli closed 7 years ago

praveenbarli commented 7 years ago

IN build cmds step4 added single quotes for java command In step 2 changed the path of jar in step 3 fixed typ0- ';' missing

codefromthecrypt commented 7 years ago

I think you meant 'below command for powershell users'

Otherwise lgtm! Thanks!

On 8 Apr 2017 7:45 am, "Praveen Barli" notifications@github.com wrote:

IN build cmds step4 added single quotes for java command In step 2 changed the path of jar in step 3 fixed type ';' missing

You can view, comment on, or merge this pull request online at:

https://github.com/openzipkin/zipkin-azure/pull/21 Commit Summary

  • added single quotes for powershell compatibility

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-azure/pull/21, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD617f6Y4gpvMkOiZ-WFNPwMVSSZKkqks5rtsqKgaJpZM4M3g1k .

praveenbarli commented 7 years ago

Changed .. I thought "Above " would convey Users that I am using the same command with syntax modificaiton..anyways chagned to "Below" as you were the User:) Thanks for reviewing!

codefromthecrypt commented 7 years ago

many thanks!