search

openzipkin-attic / zipkin-azure

Reporters and collectors for use in Azure
Apache License 2.0
11 stars 9 forks source link

Adds instructions that don't require a build #26

Closed codefromthecrypt closed 7 years ago

codefromthecrypt commented 7 years ago

After updating to latest zipkin, we no longer need to extract the module jar. This simplifies integration to 3 steps.

codefromthecrypt commented 7 years ago

cc @prbarl

codefromthecrypt commented 7 years ago

@llinder or @devinsba mind duping this for zipkin-aws? should work

codefromthecrypt commented 7 years ago

like here https://github.com/openzipkin/zipkin-aws/blob/master/autoconfigure/collector-sqs/README.md#usage

aliostad commented 7 years ago

What is the status of this?

codefromthecrypt commented 7 years ago

should work. just re-tried it. @aliostad mind verifying?

aliostad commented 7 years ago

Sure will do this afternoon.

codefromthecrypt commented 7 years ago

ps this approach works when both things downloaded are an unextracted jar. In docker, the base image is extracted, so keeping things as is there (ex extract the eventhub jar) is more likely to work.

I have the simpler instructions here in efforts to reduce steps for those trying ad-hoc.

aliostad commented 7 years ago

It works!

aliostad commented 7 years ago

ps this approach works when both things downloaded are an unextracted jar. In docker, the base image is extracted, so keeping things as is there (ex extract the eventhub jar) is more likely to work.

I was about to suggest doing this for docker, too. No?

codefromthecrypt commented 7 years ago

I was about to suggest doing this for docker, too. No?

a couple weeks ago I tried and it didn't work (when the primary thing is unzipped as is the case with zipkin-server). I didn't get to the bottom of it, and may not have raised an issue.

aliostad commented 7 years ago

Thank you will give it a go. I think this week I will probably get to run a trial in ku8 with EH collector.