search

openzipkin-attic / zipkin-azure

Reporters and collectors for use in Azure
Apache License 2.0
11 stars 9 forks source link

Adds support for Microsoft Azure Application Insights(AppInsights) as a datastore for Zipkin #27

Closed praveenbarli closed 5 years ago

praveenbarli commented 7 years ago

This PR contains changes for supporting Microsoft Azure Application Insights as a data store for Zipkin.

marcote commented 7 years ago

Hi there. Any update around this PR approval? I'm trying to create a docker images (without luck so far) and this PR not approved yet makes things a little more difficult.
If interested, the docker image code is here: https://github.com/marcote/zipkin-appinisights-docker Thanks

SergeyKanzhelev commented 7 years ago

@marcote, thanks for interest. @praveenbarli and I working on some refinements on how spans should be stored. This way we will be able to see spans natively in Application Insights and see Application Insights's collected data in Zipkin. We've estimated another week to complete this work

praveenkbarli commented 7 years ago

@marcote Nice to see you trying out this PR. We are working with admins @adriancole @aliostad to get this checked in. However I would like you to continue with your setup and let I and @SergeyKanzhelev know if you face any challenges. That way we can work in parallel and also a succesfull installation and testing in your system would be a positive push for admins to review/check in changes.

codefromthecrypt commented 5 years ago

as discussed with @dhaval24 and others at dinner last week. The way to move things forward is to change this into a "write only" component by making it a combination of translator (zipkin2 -> azure span) a sender (for zipkin-reporter meaning apps can embed it), and possibly a write-only storage component which can allow a zipkin server to proxy spans to your service. Possibly you'd also want a brave component if you are using trace context format with some azure specific trace state.

key things that are still the case are that we'd want some end user involved to help justify the community efforts which result in new code. For example, even the existing code I have done dozens of releases and that's something we shouldn't do unless end users are benefiting.

For reference, here's the zipkin-gcp repo which has functionality you'd want https://github.com/openzipkin/zipkin-gcp

dhaval24 commented 5 years ago

@adriancole thanks a lot for bringing this back! Though, I still do not fully get this work, here is what my understanding is:

  1. This would enable the ZipKin view for people using AzureMonitor on Zipkin UX. Am I correct ?

A question is:

  1. Would the reverse be true? Will the spans emitted from sleuth able to be viewed on AzureMonitor UX for tracing ?

Apologies if this is a very rudimentary question, but I am very new to Sleuth / Zipkins / Brave world :) @nikmd23 can comment on the justification, we did had many customers who were using Application Insights for Java with SpringBoot applications and were interested in getting slueth spans reported to AzureMonitor and be able to view the E2E traces on Azure UX.

codefromthecrypt commented 5 years ago

If this is write-only then it wouldn't allow use of zipkin UI, rather only your UI. However, it is better to tease functionality apart like this as otherwise it is endless. For example, not only did this stall out, but also another attempt like influx. Rather than going for gold, probably best to start with writing, then see if there is value moving forward in readback etc.

On Wed, Oct 3, 2018 at 12:54 AM Dhaval Doshi notifications@github.com wrote:

@adriancole https://github.com/adriancole thanks a lot for bringing this back! Though, I still do not fully get this work, here is what my understanding is:

  1. This would enable the ZipKin view for people using AzureMonitor on Zipkin UX. Am I correct ?

A question is:

  1. Would the reverse be true? Will the spans emitted from sleuth able to be viewed on AzureMonitor UX for tracing ?

Apologies if this is a very rudimentary question, but I am very new to Sleuth / Zipkins / Brave world :) @nikmd23 https://github.com/nikmd23 can comment on the justification, we did had many customers who were using Application Insights for Java with SpringBoot applications and were interested in getting slueth spans reported to AzureMonitor and be able to view the E2E traces on Azure UX.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-azure/pull/27#issuecomment-426349380, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD61_vp-oFzidth0UWrHoj0Q_4Zu5fiks5ug5pMgaJpZM4NWXbJ .

codefromthecrypt commented 5 years ago

closing because.. well it has been well over a year