search

openzipkin-attic / zipkin-azure

Reporters and collectors for use in Azure
Apache License 2.0
11 stars 9 forks source link

Adding a feature for an event hub sender #42

Open dcuenot opened 6 years ago

dcuenot commented 6 years ago

Hi,

Is it possible to add a feature to an event hub sender?

Indeed, I would like to use zipkin-azure on a Spring Boot application and to send my logs to an Azure EventHub. To do that, I need to have a Hub Sender, but I can't find it :)

Thanks for your help! Damien

aliostad commented 6 years ago

Hi Damien,

We started this project since I had a need to send Zipkin traces to EventHub from .NET. I do not believe there is a dedicated sender but I have been working on a project called Psyfon to build one for .NET and I have been thinking to port to it to JVM (perhaps in Scala).

Would that be of any use to you?

Cheers Ali

dcuenot commented 6 years ago

Hi,

This is a good first point. I will have a look, but I'm not an expert in .NET and scala :) I have a lot of things to learn !

aliostad commented 6 years ago

Not to worry, as I said, I am planning to do that but feel free to jump in. I will update the progress here.

codefromthecrypt commented 6 years ago

FYI, a sender here should be a zipkin2.reporter.Sender as anything else won't plug into applications the same way as the default transports do

ex a copy/paste/find/replace/adjust of something like this except using the eventhub lib instead of kafka https://github.com/openzipkin/zipkin-reporter-java/tree/master/kafka11

For example, a sender like this will work out-of-box in spring boot, dropwizard, spring xml and anything else

dcuenot commented 6 years ago

I will try to contribute. Zipkin and Azure are a little bit new for me, but I will do my best

aliostad commented 6 years ago

Thanks @adriancole that is great help. I can review and come back to it. By the way, is scala supported for Zipkin codebase?

codefromthecrypt commented 6 years ago

We intentionally rewrote the server to not be in scala a couple years back ;)

Especially due to dependency sensitivity, matrix builds etc, it can be very troublesome to folks who dont know it or the complexities therein. We have no boilerplate for scala matrix releases and there isnt likely to be one. Projects that dont require scala shouldnt be scala in other words especially core infra like transport.

In openzipkin-contrib though.. there is an empty repo for akka there which could go either way. Any native scala projects likely if we add instrumentation would also be in scala. For example I help with the play stuff which makes sense to be scala.

aliostad commented 6 years ago

That is cool. Java it is.