search

openzipkin-attic / zipkin-azure

Reporters and collectors for use in Azure
Apache License 2.0
11 stars 9 forks source link

Adds short environment variables and starts clarifying instructions #9

Closed codefromthecrypt closed 7 years ago

codefromthecrypt commented 7 years ago

This uses a spring profile to make configuration like other Zipkin components. This doesn't prevent property file configuration, rather suggests the same style here as we do elsewhere.

This also cleans up tests and simplifies the startup instructions.

Ex.

cd /tmp
EVENTHUB_CONNECTION_STRING=foo
EVENTHUB_STORAGE_CONNECTION_STRING=bar
java -Dloader.path=eventhub -Dspring.profiles.active=eventhub -cp zipkin.jar org.springframework.boot.loader.PropertiesLauncher

You'll notice the convention of using the same directory of loader path as the server profile. This is intentional as I think it will make docker or other server setup easier. For example, the java command can be templated.

Fixes #5 See #7

codefromthecrypt commented 7 years ago

cc @shakuzen @devinsba @llinder - we should replicate this for zipkin-aws

codefromthecrypt commented 7 years ago

thanks! I'll cut a minor release in a bit (which incidentally will test if publishing works properly, and allow us to start on docker)

aliostad commented 7 years ago

I see, thanks!