operator-framework / enhancements

Apache License 2.0
9 stars 40 forks source link

Add EP for CatalogSource pod spec override #104

Closed perdasilva closed 10 months ago

perdasilva commented 2 years ago

Signed-off-by: Per G. da Silva perdasilva@redhat.com

Description

#2454 asks for a way to override parts of the pod spec supplied to the underlying pod created when spec.sourceType == grpc and spec.image is defined.

This EP outlines a few different options to address this issue

fgiloux commented 2 years ago

I'm not clear on why it's important that the catalogsource be running on a particular node? I would think it would matter more where each operator pod is scheduled. I just want to make sure we're not trying to solve the latter with the former.

Generally it should be possible for a cluster-admin to decide on which node any pod, including the ones created for the catalogsource is running. There are several reasons for that:

gallettilance commented 2 years ago

@fgiloux Thanks - I see how it's a nice to have but I'm worried that the above points don't really apply to the catalogsource pod that is only serving a grpc endpoint. I feel these points apply more to workloads deployed from the catalog by OLM - which is unrelated to where the catalog pod is running. I just don't want users of this feature to get the wrong idea.