search

operator-framework / enhancements

Apache License 2.0
9 stars 40 forks source link

WIP [SDK] - Proposal to split Helm/Ansible on their repos #44

Closed camilamacedo86 closed 2 years ago

camilamacedo86 commented 4 years ago

This proposal has tables and images. I'd recommend you use its preview to check out.

TODO

camilamacedo86 commented 4 years ago

Hi @estroz,

Really thank you for your time and review. it was exactly the kind of feedback that I was looking for to make this proposal more detailed and mature. See that I address more details as simplified it. Fell free to re-check.

camilamacedo86 commented 4 years ago

Hi @shawn-hurley,

Really thank you for your input here.

Is there a concern that by separating these, it can encourage feature skew between the types of operators? I wonder if there is some mitigation that we can put in place to make sure we don't do that?

`outdated reply` It is one of the motivations of the `User Storie: Make upstream plugin Boilerplates public`.~~ The behaviours and configs which are common for all are defined in the config dir and in the Makefile. The idea here is to use directly the KB(upstream) code which also would avoid the effort to get its changes as well. And then, as a follow up we might able to have a Lib as described in `Alternatives: SDK Operator Build Lib`. However, as we have not the plugin phase 2 implemented and defined as other points shows that would be easy we try to reduce the complexities and then, try to address the needs step by step. (first split with the code and remove the duplications by centralizing it in upstream, then after the plugin phase 2 get done we might have a common config base plugin responsable to scaffold the config dir and Makefile which will be customized by the Operator Types and then we maybe can improve it to address other requirements by offering a lib with helpers for other Operator Types) I tried to supplement the doc please let me know if has something that would need further detail to clarify its motivations. Also, please feel free to share your ideas and insights as well.

The prosed solution in https://github.com/kubernetes-sigs/kubebuilder/issues/2015 can solve this problem. We need to update this EP. c/c @jmrodri

camilamacedo86 commented 2 years ago

c/c @fabianvf @asmacdo I am closing this one because it is outdated. But I want to ping you in case that can help you out.