search

operator-framework / enhancements

Apache License 2.0
9 stars 40 forks source link

operator-framework/api: add new checks to the operatorhub validator #65

Closed camilamacedo86 closed 3 years ago

camilamacedo86 commented 3 years ago

Description

This proposal describes new checks to be implemented in the operator-framework/api into the OperatorHubValidator.

camilamacedo86 commented 3 years ago

HI @bentito,

I tried to address all your comments and suggestions. Feel free to re-open anyone that you think that we might still be needing to address and re-check it. Thank you for your time and feedbacks.

bentito commented 3 years ago

HI @bentito,

I tried to address all your comments and suggestions. Feel free to re-open anyone that you think that we might still be needing to address and re-check it. Thank you for your time and feedbacks.

👍

kevinrizza commented 3 years ago

/lgtm

bparees commented 3 years ago

@camilamacedo86 two comments on this:

1) for every additional check the proposal should indicate if it will be an error or a warning (and in some cases whether it is an error or a warning may depend on the k8s version the operator is targeting, namely use of deprecated/removed apis)

2) for checks that depend on the minkubeversion of the operator, it would be useful if there were a way for the user to pass a version to validate against, in case the operator doesn't specify a version or the user wants to check against a different version.

openshift-ci-robot commented 3 years ago

New changes are detected. LGTM label has been removed.

bparees commented 3 years ago

/approve

estroz commented 3 years ago

For those interested: https://github.com/operator-framework/operator-sdk/pull/4827 is a POC for out-of-tree validators. This is relevant for future k8s distro-specific validators that can't be added to an operator-framework validator. I will be submitting an EP PR to describe the solution implemented by that POC shortly.