search

operator-framework / enhancements

Apache License 2.0
9 stars 40 forks source link

enhancement: External validations for Operator SDK #98

Closed jmrodri closed 2 years ago

jmrodri commented 3 years ago

Today, validations used by CVP are compiled into the operator-sdk. Any changes to the validation rules requires a release of operator-framework/api followed by a release of operator-sdk. This proposal attempts to design a way where the validations can be hosted in their own repos as well as updated without requiring new releases of the operator-sdk.

camilamacedo86 commented 3 years ago

I tried to contribute with some comments/nits. However, otherwise, it seems amazing to me 🥇.

I think that can be very helpful for we are able to do specific checks and allow the users/community to create their own checks.

Terrific job @jmrodri!

jmrodri commented 2 years ago

Implementation https://github.com/operator-framework/operator-sdk/pull/5525

ryantking commented 2 years ago

/hold Have an in-progress review that I'll finish in the next 3 hours

jmrodri commented 2 years ago

@ryantking I think I addressed your comments. Let me know if you want me to add a more explicit link to the ManifestResult struct or anything else.

jmrodri commented 2 years ago

I will add the validator example on Monday.

jmrodri commented 2 years ago

@ryantking I don't see the funky formatting when I view the rendered file in github: validatorn-ep.pdf

jmrodri commented 2 years ago

@camilamacedo86 if you want discoverability to be part of this EP, let me know so we can discuss how we think we should do that. @ryantking is currently working on some validators.

jmrodri commented 2 years ago

/hold cancel

jmrodri commented 2 years ago

@camilamacedo86 @ryantking I'm merging this EP. If we need to add more we can definitely enhance this enhancement (just updating the same one would be fine).