search

opral / inlang-sherlock

Issue tracker for Sherlock
https://marketplace.visualstudio.com/items?itemName=inlang.vs-code-extension
2 stars 0 forks source link

Cannot extract messages from certain filetypes #12

Closed dallyh closed 6 months ago

dallyh commented 6 months ago

Hello, Sherlock does not seem to pick up some file types regarding extraction of messages in VSCode. The suggestions menu (light bulb / crtl + .) is empty for some of the file types I'm using. For example .ts files do get picked up and suggestions are populated with the Inlang: Extract Message entry, but in other files like .astro the entry is not in the suggestions menu.

Typescript file: image

Astro file: image

I don't know if this is an issue because .astro is a specific filetype for Astro framework, and it has it's own language server / vscode extension, or if it is just that some files are currently not supported. My guess is it's the former, because i18n-ally extension worked fine with key extraction.

linear[bot] commented 6 months ago

SHERL-14 Cannot extract messages from certain filetypes

felixhaeberle commented 6 months ago

@dallyh PR https://github.com/opral/monorepo/pull/2443

What's the language id for astro files? astro ?

See my comment here: https://discord.com/channels/897438559458430986/1220506411344068691/1220509431784280105

felixhaeberle commented 6 months ago

fixed with https://github.com/opral/monorepo/pull/2443