opral / inlang-sherlock

Issue tracker for Sherlock
https://marketplace.visualstudio.com/items?itemName=inlang.vs-code-extension
2 stars 0 forks source link

Implement a Language Server #49

Closed mcchrish closed 1 month ago

mcchrish commented 1 month ago

Originally requested in i18n-ally but found out that it's not getting maintained these days.

https://github.com/lokalise/i18n-ally/issues/1146

But overall having a language server allow support to other editors that has LSP support.

samuelstroschein commented 1 month ago

Thoughts:

mcchrish commented 1 month ago

Language server can also be a great conceptual choice to structure your code where "main" functionalities goes to the server and the vscode plugin will just be client making those functionalities available to vscode users. And you can of course just continue maintaining the vscode plugin and can let other editor communities maintainer their own "plugin"/client.

This is the direction Tailwind have taken: https://github.com/tailwindlabs/tailwindcss-intellisense. Which have given way for the neovim users to create their own plugin: https://github.com/luckasRanarison/tailwind-tools.nvim

samuelstroschein commented 1 month ago

yeah i understand the value behind LSP. ultimately, @felixhaeberle's decision. but lsp will likely not lead to third party sherlock extensions. the majority of code in sherlock doesn't concern itself with LSP related features

felixhaeberle commented 1 month ago

I'm open to discussing this further, but I don't see a value in this right now. Converting it to a discussion.