search

oracle / coherence

Oracle Coherence Community Edition
https://coherence.community
Universal Permissive License v1.0
427 stars 71 forks source link

published source jar lacks Java sources #131

Open ben-manes opened 3 days ago

ben-manes commented 3 days ago

Describe the bug The releases on Maven Central include a -source jar which should allow an IDE to open the class sources if available. It appears that this may have been unintentionally lost when modifying the build, likely in Bug 35429969 - [35265307->23.09] Some of the coherence jars in latest patch are missing manifest file entries when the maven-jar-plugin configuration is overridden.

To Reproduce

$ wget https://repo1.maven.org/maven2/com/oracle/coherence/ce/coherence/24.09/coherence-24.09-sources.jar
$ jar -tf coherence-24.09-sources.jar
META-INF/
META-INF/MANIFEST.MF
META-INF/versions/
META-INF/versions/21/
META-INF/versions/21/META-INF/
META-INF/versions/21/com/
META-INF/versions/21/com/tangosol/
META-INF/versions/21/com/tangosol/internal/
META-INF/versions/21/com/tangosol/internal/util/
META-INF/maven/
META-INF/maven/com.oracle.coherence.ce/
META-INF/maven/com.oracle.coherence.ce/coherence/
META-INF/versions/21/META-INF/LICENSE.txt
META-INF/versions/21/META-INF/THIRD_PARTY_LICENSES.txt
META-INF/versions/21/com/tangosol/internal/util/ExceptionHelper.class
META-INF/versions/21/com/tangosol/internal/util/VirtualThreads.class
META-INF/maven/com.oracle.coherence.ce/coherence/pom.xml
META-INF/maven/com.oracle.coherence.ce/coherence/pom.properties

Expected behaviour

$ wget https://repo1.maven.org/maven2/com/oracle/coherence/ce/coherence/23.03.1/coherence-23.03.1-sources.jar
$ jar -tf coherence-23.03.1-sources.jar | grep \\.java | head
com/oracle/coherence/persistence/PersistenceException.java
com/oracle/coherence/persistence/PersistenceTools.java
com/oracle/coherence/persistence/PersistenceStatistics.java
com/oracle/coherence/persistence/PersistenceManager.java
com/oracle/coherence/persistence/package-info.java
com/oracle/coherence/persistence/PersistenceEnvironment.java
com/oracle/coherence/persistence/ConcurrentAccessException.java
com/oracle/coherence/persistence/OfflinePersistenceInfo.java
com/oracle/coherence/persistence/FatalAccessException.java
com/oracle/coherence/persistence/AsyncPersistenceException.java

Screenshots

Screenshot 2024-11-19 at 5 56 19 PM
aseovic commented 2 days ago

Damn... Thanks for reporting this. Not much we can do about stuff that's already published, but we'll make sure it's fixed in the next patch.