search

oracle / coherence

Oracle Coherence Community Edition
https://coherence.community
Universal Permissive License v1.0
427 stars 70 forks source link

A ConfigurableCacheMap backed by Caffeine #60

Closed ben-manes closed 2 years ago

ben-manes commented 2 years ago

This is ready for review of the implementation, code quality, and testing.

Some procedural cleanups are expected,

  1. No effort was put into reformatting to the project's style guide.
  2. I am rusty at Maven and expect that needs some cleaning up, e.g. tests do not run at command-line.
  3. A pre-release version of Caffeine is used, but that can be released whenever this is ready

Fixes #16 /cc @aseovic @mgamanho

aseovic commented 2 years ago

@ben-manes I finally found some cycles to reformat the code according to Coherence coding conventions (6-hour flights occasionally come handy ;-)), and have asked @dhirupandey to request 3rd party approval for Caffeine so we can merge the PR.

One thing that you still have to do is add missing javadoc. I think I highlighted most area where this is necessary by creating empty javadoc blocks, but in general, we require javadoc on pretty much everything other than the inherited/overriden methods (unless you want to document difference in behavior). This includes private fields, classes, methods, etc.

Once you do that I will make one last pass, and hopefully by the time we are done with that we'll have the necessary approvals to merge it into the mainline as well.

ben-manes commented 2 years ago

Thanks @aseovic! Updated with the additional javadoc.

coherence-bot commented 2 years ago

Failed to process pull request Failed checking RQ statuses for this pull request.

oracle-contributor-agreement[bot] commented 2 years ago

Oracle requires that contributors to all of its open-source projects sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

In order to sign the OCA, you need to create an Oracle account and sign the OCA in the Oracle's Contributor Agreement Application by following the steps on the homepage.

When singing the OCA, please provide your GitHub username. By doing so, this PR will be automatically updated once the signed OCA was approved by Oracle.

coherence-bot commented 2 years ago

Failed to process pull request Failed checking RQ statuses for this pull request.

ben-manes commented 2 years ago

Merged via f00862eda483ce94a6d99df8971926bcd9e848db