oreillymedia / docbook2asciidoc

XSL for transforming DocBook to AsciiDoc
MIT License
61 stars 33 forks source link

Add space after "_" on italic in docbook2asciidoc #1

Closed sandersk closed 12 years ago

sandersk commented 12 years ago

Hey, Sanders. I've been reviewing the Maker Faire Playbook, and it looks like there are a few issues that have turned up in the docbook2asciidoc conversion script. (Probably)

It looks like the italic markup is not putting a space after the final "_" character, as shown in these examples:


. _Performers._Musicians and dancers and snake charmers fit this group. They are the stage show.

. _Speakers._You might choose to have workshops or lectures or panel discussions at your Faire. Speakers might or might not have an actual booth at your Faire.

. _Exhibiting Sponsors._You won’t use the Call for Makers for finding sponsors (it’s really a hand-held, high-touch activity), but if and when you secure sponsors and they would like exhibit at your Faire, you will want to track them and feed them information like any other maker. Having them fill out a Call for Makers form (or you doing it for them) will ensure that these exhibiting sponsors receive all necessary production information.

The results in funky italics.

Can you take a look?

Andrew

sandersk commented 12 years ago

Took a look at the DocBook source from which the AsciiDoc in question was generated, and it turns out these sections were formatted using s, e.g.:

<listitem><formalpara><title><emphasis role="strong">Performers.</emphasis></title><para>Musicians and dancers

So this is actually not a problem with italic processing; the issue is that d2a.xsl doesn't support yet, so I will add support for it.

sandersk commented 12 years ago

Resolving as a duplicate, as spacing problems noted here are covered in the following 2 issues:

https://github.com/oreillymedia/docbook2asciidoc/issues/6 https://github.com/oreillymedia/docbook2asciidoc/issues/7

Issue #6 regarding handling of has been fixed, and I've committed updated versions of the AsciiDoc for How to Make a Maker Faire to Atlas.