oria / gridx

Just another powerful Dojo grid
Other
162 stars 78 forks source link

unexpected Row Height increasing In IE11 #426

Open jonirrings opened 5 years ago

jonirrings commented 5 years ago

this bug only occurs in IE put this in gridx/tests/

<!DOCTYPE html>
<html>
<head>
    <title>GridX Row Height Expanding Bug</title>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
    <link rel='stylesheet' href="support/common.css" />
    <script type="text/javascript" src="../../dojo/dojo.js" data-dojo-config="async: true"></script>
    <script type="text/javascript" src='support/common.js'></script>
    <script type="text/javascript" src='test_grid_edit.js'></script>
    <style type="text/css">
        .gridx {
            width: 1000px;
            height: 400px;
            margin-bottom: 20px;
        }
    </style>
</head>
<body class='claro'>
    <h1 class='title' tabindex='0' onfocus='this.style.color="blue"' onblur='this.style.color=""'>
        GridX Row Height Expanding Bug
    </h1>
    <p>This is adapted from test_grid_edit, works well under 1.2.1, but buggy under 1.3.8</p>
    <p>Double click or press ENTER on a cell to edit</p>
    <h2>Dijit as editor</h2>
    <div jsid='grid1' data-dojo-type='gridx.Grid' data-dojo-props='
        cacheClass: "gridx/core/model/cache/Sync",
        store: store1,
        structure: layout1,
        columnLockCount: 1,
        modules: [
            "gridx/modules/ColumnLock",
            "gridx/modules/RowHeader",
            "gridx/modules/IndirectSelect",
            "gridx/modules/extendedSelect/Row",
            "gridx/modules/VirtualVScroller",
            "gridx/modules/CellWidget",
            "gridx/modules/Edit",
            "gridx/modules/Pagination",
            "gridx/modules/pagination/PaginationBar"
        ]
    '></div>
    <h2>Custom editor</h2>
    <div jsid='grid2' data-dojo-type='gridx.Grid' data-dojo-props='
        cacheClass: "gridx/core/model/cache/Sync",
        store: store2,
        structure: layout2,
        modules: [
            "gridx/modules/CellWidget",
            "gridx/modules/Edit"
        ]
    '></div>
</body>
</html>

once a table cell transform into a Widget Editor, the height of every row (even the header row) increased.

this bug can be reproduced under gridx version 1.3.8, but not under 1.2.1.

anybody got any solution?

jonirrings commented 5 years ago

the mimial modulesrequired to reproduce this bug are ["gridx/modules/ColumnLock","gridx/modules/CellWidget","gridx/modules/Edit"]

jonirrings commented 5 years ago

in case that too many data will slow down IE11, you could reduce the data in store1 to size 5