search

oria / gridx

Just another powerful Dojo grid
Other
162 stars 78 forks source link

double execution of function onCellWidgetCreated in module CellWidget #95

Open fabiopellati opened 11 years ago

fabiopellati commented 11 years ago

gridx/modules/CellWidget.js at line 464

this.onCellWidgetCreated(widget, cell.column); if(col.onCellWidgetCreated){ col.onCellWidgetCreated(widget, cell.column); }

if i define onCellWidgetCreated: function(...){...}

in structure, my function will be fired twice

dartz commented 11 years ago

I just tried to programmatically create widget's inside of gridX with this feature, and have been scratching my head why I'm seeing "2" identical widgets getting created, guess I know why now :-(

I looked at the CellWidget.js, but because of time constraints I'm not familiar enough with code to see what needs to be modified.

Any pointers or suggestions?

thanks

--- Ooops, sorry, didn't see the changes to CellWidget.js, five days ago that fixed this - never mind :-(

(and thanks)

yurychika commented 11 years ago

@dartz you can take a look at this wiki page https://github.com/oria/gridx/wiki/How-to-show-widgets-in-gridx-cells%3F

And hope it helps.

nkolban commented 11 years ago

Hi guys, I'm a consumer of the GridX tables as opposed to a builder. I'm using the GridX 1.2 distribution downloaded from this site. Should I assume that this problem has not been resolved in a distribution release?

When is the next scheduled distribution release?

Neil

yurychika commented 11 years ago

Can you provide me with the link you downloaded from?

nkolban commented 11 years ago

I looked at the code patch you did for issue #95 and edited the code myself in my ZIP file ... it wasn't as scary as I thought it was and now it is working. Many thanks ... am loving GridX.