search

oscar-system / book.oscar-system.org

https://book.oscar-system.org
0 stars 6 forks source link

Change colour in logo #33

Closed joschmitt closed 3 months ago

joschmitt commented 3 months ago

I changed the yellow font in the logo to white so that one can see it on the yellow background. I can also put any other colour of course.

What about these other files like android-chrome-192x192.png? Are they used? Autogenerated? Do I need to adjust them as well? (Is there a way to preview the mobile version on a desktop?)

That's how the sidebar would look now: Bildschirmfoto vom 2024-05-24 14-19-02

aaruni96 commented 3 months ago

What about these other files like android-chrome-192x192.png

Those are most likely favicons, the small icon that shows up next to the tab in the browser.

I have no problem with this change (and I should maybe not be asked for visual aesthetic opinions), but I thought the idea was to have a small render of the book's title page (whenever that's ready) to replace the logo?

@fingolfin said in https://github.com/oscar-system/Oscar.jl/issues/3707#issuecomment-2100515274

Perhaps the book has a nice title page, then we could use a little rendering of that instead of the OSCAR logo?

joschmitt commented 3 months ago

I have no problem with this change (and I should maybe not be asked for visual aesthetic opinions), but I thought the idea was to have a small render of the book's title page (whenever that's ready) to replace the logo?

@fingolfin said in oscar-system/Oscar.jl#3707 (comment)

Perhaps the book has a nice title page, then we could use a little rendering of that instead of the OSCAR logo?

Ah, okay, I missed that. But it also doesn't contradict the current change? I'm a fan of pragmatic solutions now which can always be replaced by great solutions in the future :)

HereAround commented 3 months ago

I like the proposal of @joschmitt .