oscar-system / book.oscar-system.org

https://book.oscar-system.org
0 stars 6 forks source link

Ak96/fix title #5

Closed aaruni96 closed 4 months ago

aaruni96 commented 4 months ago

Fixes title of the website, also changes the sidebar color. I didn't know what to color the sidebar, so I just made it a "springer yellow", because the book is published with springer. Maybe someone with a better sense of aesthetics can comment on this choice.

(The "springer yellow" conflicts with the logo image, but since we plan to replace that anyway, it shouldn't be a problem.)

Addresses parts of #4

HereAround commented 4 months ago

From the code sprint discussions this afternoon, I understand that the different color should just distinguish the book website from the oscar system website. As such, the springer yellow nicely differs from the gray used for the oscar system website.

(Btw.: I was not yet aware that the logo image will be changed.)

aaruni96 commented 4 months ago

(Btw.: I was not yet aware that the logo image will be changed.)

Max suggested it as an option in https://github.com/oscar-system/Oscar.jl/issues/3707#issuecomment-2100515274 , and I agree. Maybe we will have to change the shade of yellow to make the render icon still be distinct from the sidebar, but that depends on how exactly the book render looks.

Alternatively, we can just add a different color background+margin to the render icon.

fieker commented 4 months ago

On Wed, May 08, 2024 at 08:07:30AM -0700, Martin Bies wrote:

@HereAround commented on this pull request.

-tagline: 'OSCAR Computer Algebra System' +tagline: 'The Computer Algebra System OSCAR'

Proposal for long title: "The OSCAR Book Companion: Code Examples and Errata". Proposal for short title: "The OSCAR Book Companion".

@fingolfin @fieker , what are your thoughts? Good thinking, I like that

-- Reply to this email directly or view it on GitHub: https://github.com/oscar-system/book.oscar-system.org/pull/5#discussion_r1594203158 You are receiving this because you were mentioned.

Message ID: @.***>