search

osrf / capabilities

Implements the concept of capabilities as part of the robots-in-concert system.
Other
8 stars 26 forks source link

Allow request for specific capabilty specification in GetCapabilitySpecs #21

Closed bit-pirate closed 10 years ago

bit-pirate commented 10 years ago

Currently the response of this service call contains all capability specs, which probably will be a lot in the near future. Hence, I'd like to have the option to request a specific capability specification.

wjwwood commented 10 years ago

I can add a service for this, but how are you using this service currently? I would recommend you use the capabilities.service_discovery module. It does everything for you.

What use case do you have to need to fetch individual specs? They shouldn't be changing very frequently, i.e. this should be a one time cost to transfer the specs between nodes (potentially on different machines).

I actually see this service as an implementation detail of the rqt visualization tool. Originally I had planned for nodes on the same machine as the capability server to discover and load the capability specs using the same method as the capability server, using the capabilities.discovery module.

wjwwood commented 10 years ago

Do we still want this type of service?

bit-pirate commented 10 years ago

I would just modified the current service to allow providing the name of the spec one wants to receive (currently the request is empty). Convenient would be, if the requested spec name is empty, all specs will be send.

However, this is not of high priority, since I started to use the python library, which is very convenient.

wjwwood commented 10 years ago

Upgraded to pull request.

coveralls commented 10 years ago

Coverage Status

Changes Unknown when pulling ae8555af8e70098bac75e3a1b466a931e2303d28 on issue_21 into \ on master**.