search

osrf / capabilities

Implements the concept of capabilities as part of the robots-in-concert system.
Other
8 stars 26 forks source link

Use the absolute nodelet manager name for starting caps #66

Closed bit-pirate closed 10 years ago

bit-pirate commented 10 years ago

The ~/get_nodelet_manager_name service already returns the absolute name. Internally however, only the nodelet manager name itself is stored and used. This approach fails, when nodelets are loaded from within a namespace.

Suggestion:

Move the logic for retrieving the absolute name out of the service callback (https://github.com/osrf/capabilities/blob/master/src/capabilities/server.py#L915-L917) and into the LaunchManager class, which stores the name (https://github.com/osrf/capabilities/blob/master/src/capabilities/launch_manager.py#L100).

bit-pirate commented 10 years ago

Preparing a fix now.

bit-pirate commented 10 years ago

@wjwwood PR #67 is my suggestion for fixing this. Let me know, if there is a more elegant/better way to implement this.