search

osrf / capabilities

Implements the concept of capabilities as part of the robots-in-concert system.
Other
8 stars 26 forks source link

Add queue_size arg for all publishers #74

Closed jonbinney closed 10 years ago

jonbinney commented 10 years ago

Otherwise rospy gives warnings on indigo. I mostly picked "10" randomly as the queue size. The one exception is that I used 1 for the queue_size of the cmd_vel publisher, since that's a pretty common thing to do (robots always want the most recent command)

wjwwood commented 10 years ago

Thanks!

I would argue that the queue_size should be larger for ~events, and maybe even 0, since I really don't want any events to be dropped if at all possible. I suppose that it is possible that the queue fills up if a subscriber connection is locked up for a prolonged period of time. Then again maybe I'm paranoid and 10 is fine.

jonbinney commented 10 years ago

How about 1000? The problem with an infinite queue size is that if a client drops off the network (bad wifi) then rospy hangs.

wjwwood commented 10 years ago

I thought rospy would only hang if it was synchronous, and that 0 was asynchronous but infinite.

Lets just go with 1000.

jonbinney commented 10 years ago

K I'll update the PR

wjwwood commented 10 years ago

Thanks.

jonbinney commented 10 years ago

Done

jonbinney commented 10 years ago

Travis failed because it couldn't run pip :-(

wjwwood commented 10 years ago

I kicked it, should be good in a few minutes.

bit-pirate commented 10 years ago

Looks good now. Merge?