moriarty
commented
4 years ago @iche033 & @chapulina I must admit I'm no expert in nodejs so this might be a hack.
There are some deprecated and old tags for gzweb here: https://hub.docker.com/r/osrf/gazebo/tags
And there are no images or tags of gzweb in the new official location here: https://hub.docker.com/_/gazebo/tags
The images here: https://github.com/osrf/docker_images are out of date https://github.com/osrf/docker_images/blob/master/gazebo/9/ubuntu/bionic/gzweb9/Dockerfile and haven't been updated since the bitbucket transition https://github.com/osrf/gazebo_tutorials/pull/118 but they also needed a few more changes.
In general, the old gzweb docker_image in https://github.com/osrf/docker_images seems more like an sample of how to put gzweb into docker, it starts a gzserver (without many plugins available or the mechanisms to load custom ones in place) and gzweb which is probably not what it would do in. @mikaelarguedas might have some insight here as I've opened issues to docker_images in the past and to use them in practice usually you end up writing your own.
In practice, I believe it's possible to create a generic gzweb docker image, which is not aware of all the required models ahead of time, but when brought up with kubernetes or docker-compose, unknown models could be volume mounted to the gzweb container, and added to the GAZEBO_MODEL_PATH environment variable, and the command run by gzweb would first re-run deploy -m and then run start...
Not actual code, just an example of how this change would enable updating the official gzweb images for generic use:
version: "3"
gz-server:
...
volumes:
- gz-server-models:/path/to/the/actual/models
gz-web:
image: could.be.official.registry/gzweb:latest
depends_on:
- gz-server
environment:
- GAZEBO_MASTER_URI=gz-server:11345
- GAZEBO_MODEL_PATH=/path/to/mount/models
volumes:
- gz-server-models:/path/to/mount/models:ro
command: >
bash -c "npm run deploy --- -m local
&& npm start"
volumes:
gz-server-models:
node-gyp configure will fail if build directory already exists.
One reason this might already exists is if new models have been added to the model path, and
npm run deploy --- -m localis run again.This change enables building a generic docker image for gzweb, and later loading in the models at launch time via a volume mount that were not known when the original gzweb image was built.