search

osrf / ros2multirobotbook

Creative Commons Attribution 4.0 International
123 stars 32 forks source link

Link to RobotCommandHandle.py is broken #107

Open Voldivh opened 10 months ago

Voldivh commented 10 months ago

On the file integration_fleets.md there is a link to the RobotCommandHandle.py file which is a partial implementation of this class that can be used as an example. However, the link is broken since the file does not exist on the main branch of the repository it redirects. I believe it can be fixed by just modifying the link from https://github.com/open-rmf/fleet_adapter_template/blob/main/fleet_adapter_template/fleet_adapter_template/RobotCommandHandle.py to https://github.com/open-rmf/fleet_adapter_template/blob/humble/fleet_adapter_template/fleet_adapter_template/RobotCommandHandle.py and stating that it is an example for ROS Humble version.

Yadunund commented 10 months ago

Hi Eloy!

Thanks for catching that issue.

Both sections, ie the template and the rmf_demos use case, need to be updated to highlight the use of our new EasyFullControl API. This approach reduces a lot of boilerplate code and makes it much simpler to write fleet adapters by simply registering certain callbacks.

We would greatly appreciate any contributions to update the documentation here!

Voldivh commented 10 months ago

Hey Yadu!

No worries, I was checking the latest documentation (it have improved a lot since last time I saw it, congrats!) for some project I'm working on.

I can certainly try to help out on this and related issues, if that's not possible at least I'll file the issues I find so someone else can take charge of them.

Yadunund commented 10 months ago

That sounds great! Thanks!