search

osrf / ros2multirobotbook

Creative Commons Attribution 4.0 International
123 stars 32 forks source link

Update ubuntu version #88

Closed xiyuoh closed 2 years ago

xiyuoh commented 2 years ago

The book is currently deployed on an Ubuntu 18.04 machine (glibc 2.27) which raises the following error since the latest version of mdbook requires glibc 2.29:

mdbook: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.29' not found (required by mdbook)

and the book doesn't compile accordingly. This PR uses Ubuntu 20.04 (glibc 2.31) for deployment instead.

Yadunund commented 2 years ago

Seems like CI is only configured to run when a commit is pushed to master.

It will be best if it runs for any push and also for pull requests to make sure no breaking changes get merged.

Could you change the yaml to

on: [push, pull_request]
xiyuoh commented 2 years ago

Done!