oss-tsukuba / gfarm

distributed file system for large-scale cluster computing and wide-area data sharing. provides fine-grained replica location control.
Other
32 stars 12 forks source link

incomplete replica is left, if malloc(3) fails #500

Closed gfarm-admin closed 4 years ago

gfarm-admin commented 12 years ago

This is a sub-ticket of #408 (incomplete replica is left),
and described as comment:24:ticket:408.

this problem hardly happens, though.
(only happens at malloc(3) failure for really small size)

the main issue:
the problem happens when async_back_channel_replication_request() returns GFARM_ERR_NO_MEMORY.
it was introduced in r4480 for #37 (gfarm-2.4.0),
and exists on the 2.5 branch and 2.5.7 branch,
it doesn't exist on the main trunk, because the main truk was fixed in r6235 to implement #142 (generic send queue for backchannel for gfmd).
pointed out by Takuya Ishibashi-san (takuya-i@).

there was another issue on the trunk (and trunk only), though:
the trunk problem was introduced in r6235 to implement #142 (generic send queue for backchannel for gfmd) on the main trunk, and doesn't exist on the 2.5 branch.

Reported by: takuya-isbs

Original Ticket: gfarm/tickets/500

gfarm-admin commented 12 years ago

Original comment by: n-soda

gfarm-admin commented 12 years ago

Original comment by: n-soda

gfarm-admin commented 12 years ago

Replying to takuya-i:

this problem was introduced to fix #372 in r6207 (2.5 branch, gfarm-2.5.5) and r6208 (trunk).

that was wrong. sorry for the confusion.

in reality, this problem was introduced in r6235 to implement (#142 - generic send queue for backchannel for gfmd), and doesn't exist on the 2.5 branch.

Original comment by: n-soda

gfarm-admin commented 12 years ago

Original comment by: n-soda

gfarm-admin commented 12 years ago

fixed in r6898

Original comment by: n-soda

gfarm-admin commented 12 years ago

remove milestone and version from this ticket, because released versions don't have this problem.

Original comment by: n-soda

gfarm-admin commented 12 years ago

Original comment by: n-soda

gfarm-admin commented 12 years ago

what Ishibashi-san intended was another problem

Original comment by: n-soda

gfarm-admin commented 12 years ago

Original comment by: n-soda

gfarm-admin commented 12 years ago

Replying to n-soda:

fixed in r6898

this is about a problem on the main trunk.

for the main issue (i.e. the issue on the 2.5 and 2.5.7 branch) was fixed in r6909

Original comment by: n-soda

gfarm-admin commented 11 years ago

r6909 on the 2.5 branch was merged into the 2.5.7 branch in r7363 as part of a pullup ticket #485

Original comment by: n-soda