search

otakup0pe / avakas

Tooling to assist with Semantic Version Manipulation and Representation
http://ohno.computer/post/144362045508/a-codified-opinion-on-semantic-versioning
MIT License
2 stars 5 forks source link

Avakas will attempt to commit changes even when the version is the same as the existent version #66

Open tyler-jachetta opened 3 years ago

tyler-jachetta commented 3 years ago

The fact that the auto bump is setting the version to the same version in the case I found is captured in #63 . I think that attempting to change the version to what it currently is seems like a bad thing. In our circleCI work, this led to a no changes commit happening saying that it was bumping the version (in that it made a commit to commit the version file, but since no changes...).

I'm not sure how we want to handle it exactly, but should we do something like raise some sort of AvakasError if we try to set the version to the get result?

my 2c is that testing this sort of functionality lies inside of unit tests. Gonna whip up a quick PR with some unit tests to test this (unless I should not persue)

otakup0pe commented 3 years ago

This does feel like a gap in testing and ux. Even ignoring the underling issue with prerelease there is always the manual set action.