search

otakup0pe / avakas

Tooling to assist with Semantic Version Manipulation and Representation
http://ohno.computer/post/144362045508/a-codified-opinion-on-semantic-versioning
MIT License
2 stars 5 forks source link

Fix successive prereleases bug (issue 63) #70

Closed tyler-jachetta closed 3 years ago

tyler-jachetta commented 3 years ago

fixes #63, by integrating the prerelease version bump into the main version bump

As a follow up to this, I should add specific tests for prerelease work to flavors which implement their own versions of any part of the bump, just to be certain of consistency

All tests are passing. I think it may be ready, but given that it's a larger code change, I want to get a good review of it before making this a real PR

tyler-jachetta commented 3 years ago

I took a careful look at this ^^. The only blocking change I'd ask for is that cli_set_version is updated to have the same prerelease_date code that was added to cli_bump_version, so that its behaviour can remain the same after this patch is applied.

oooh good catch, I should also write tests around it that currently fail before tidying that up

tyler-jachetta commented 3 years ago

👌

Appreciate your eyes on this 😊

tyler-jachetta commented 3 years ago

There's a good argument for merging #74 in first, so that the testing in there can be directly applied to this in CI (I ran these locally but I always like to be able to rely on my automation when I can)