search

otakup0pe / avakas

Tooling to assist with Semantic Version Manipulation and Representation
http://ohno.computer/post/144362045508/a-codified-opinion-on-semantic-versioning
MIT License
2 stars 5 forks source link

[issue 81] #82

Closed tyler-jachetta closed 2 years ago

tyler-jachetta commented 3 years ago

Initially creating PR with only failing test, will fill in with additional work as it is done This new test fails, expressing the bug #81

tyler-jachetta commented 3 years ago

I think that these tests may also need to include versions with and without prefixes (v1.2.3 vs 1.2.3)

otakup0pe commented 3 years ago

I mean, the test fails. Will the fix be in this pr?

tyler-jachetta commented 3 years ago

I planned to do that once I did the work to fix the issue, but I can slice it up either way, can also just close this issue having referenced it in the issue (#81)

otakup0pe commented 3 years ago

Let's fix it in this PR so we aren't merging things with broken tests into mainline.

tyler-jachetta commented 3 years ago

oh, not what I meant, sorry. Two options I was presenting was use this PR, or use a fresh PR and drop this one (never committing/merging)

otakup0pe commented 3 years ago

Gotcha. I don't care either way, just don't want to see merging in things with broken tests heh.

tyler-jachetta commented 2 years ago

I can't for the life of me figure out why mainline doesn't exist in CI, @otakup0pe do you have any ideas/does make test off of this branch pass for you locally?

tyler-jachetta commented 2 years ago

Oh I think it might be because the branch isn't on otakup0pe/avakas, this makes sense

tyler-jachetta commented 2 years ago

and after all that Sturm und Drang, got the CI figured out. Looks like I can merge this myself, but wouldn't mind a review as the changes are not minor @otakup0pe

tyler-jachetta commented 2 years ago

@otakup0pe do you want me to just trust myself here and merge? don't want to overly bother you, but also don't want to be too cavalier