otakup0pe / avakas

Tooling to assist with Semantic Version Manipulation and Representation
http://ohno.computer/post/144362045508/a-codified-opinion-on-semantic-versioning
MIT License
2 stars 5 forks source link

Should tag prefixes show up in CLI output #84

Open tyler-jachetta opened 3 years ago

tyler-jachetta commented 3 years ago

There aren't tests around this, what I'm gathering is that e.g. if we use the tag prefix of 'v', so version 1.2.3 has the tag v1.2.3,

avakas show output: 1.2.3 avakas set output: Version set to 1.2.3 avakas update output: Version updated from 1.2.3 to 1.2.4

is what is wanted. However, some of the code strips out the tag prefix, and others don't.

There's some uneven handling broadly, but do we have a preference for displaying the tag prefix in the CLI? If the answer is yes, the above would instead look like:

avakas show output: v1.2.3 avakas set output: Version set to v1.2.3 avakas update output: Version updated from v1.2.3 to v1.2.4

Super agnostic about this, just realized that I had some missing test coverage, and while I was looking at that, realized I had put no thought into how the tag prefixes might be handled

tyler-jachetta commented 3 years ago

@otakup0pe figure this one is a quick yes/no answer, I like the cleanliness of never showing the prefix back at people, but that's just my 2c

otakup0pe commented 3 years ago

Oof. It should definitely be consistent. I'd say that we should always present the actual string that is being preserved.