otakup0pe / avakas

Tooling to assist with Semantic Version Manipulation and Representation
http://ohno.computer/post/144362045508/a-codified-opinion-on-semantic-versioning
MIT License
2 stars 5 forks source link

`strip()` will not always behave as desired here #86

Open tyler-jachetta opened 3 years ago

tyler-jachetta commented 3 years ago

https://github.com/otakup0pe/avakas/blob/f554deafc5481768e669eb274ed96fe0d03ea521/avakas/avakas.py#L66

using strip() in this case has some issues (using v as sample prefix):

Don't have tests exercising this done yet, just saw this issue and logging it for now. No known cases of error in the wild

tyler-jachetta commented 3 years ago

also, here: https://github.com/otakup0pe/avakas/blob/f554deafc5481768e669eb274ed96fe0d03ea521/avakas/flavors/git.py#L132