search

otherlab / geode

A computational geometry library for C++ and Python
Other
86 stars 22 forks source link

Time to strip the boost version of type_traits et al.? #76

Closed girving closed 7 years ago

girving commented 7 years ago

Someone emailed me a little while ago about a build issue related to boost::type_traits: https://groups.google.com/forum/#!topic/geode-dev/gwu_igU4VbQ.

This problem would go away if the support for using type_traits and similar out of boost was stripped away, so that geode unconditionally used the std:: versions. I think that's pretty safe at this point, including on Windows (TensorFlow does it, for instance).

Here's the sort of code monstrosity that would go away: https://github.com/otherlab/geode/blob/master/geode/utility/type_traits.h#L7

I'd be happy to send a PR if it seems reasonable to others.

girving commented 7 years ago

Woohoo!