search

outmoded / university

Community learning experiment
Other
371 stars 194 forks source link

Assignment 4 #130

Closed zerok closed 9 years ago

AdriVanHoudt commented 9 years ago

general linting issues

Linting results:
    lib/private.js:
        Line 23: no-else-return - Unexpected 'else' after 'return'.
        Line 31: space-before-function-paren - Missing space before function parentheses.
    test/private.js:
        Line 14: hapi/hapi-scope-start - Missing blank line at beginning of function.
        Line 14: space-before-function-paren - Missing space before function parentheses.
        Line 89: space-before-function-paren - Missing space before function parentheses.
zerok commented 9 years ago

@AdriVanHoudt This is just plain weird. Seems like eslint is getting mixed into the linting result or something. I was running the linter constantly and got no compains in the end. Will fix them in the evening.

AdriVanHoudt commented 9 years ago

@zerok do you have the latest version of Lab? There were some rules added recently

zerok commented 9 years ago

@AdriVanHoudt I should have. The issue was that I also had a self-made .eslintrc file lying around which influenced what the linter was doing.

AdriVanHoudt commented 9 years ago

Ah that was probably it. you can always see what the test results are on travis to see the results in a 'clean' environment