search

outmoded / university

Community learning experiment
Other
371 stars 193 forks source link

Assignment #5 - Glue and HTML views #141

Closed hussainanjar closed 9 years ago

hussainanjar commented 9 years ago

Completed assignment 5.

Kept Glue manifest in external json file under config folder.

Closes #136

AdriVanHoudt commented 9 years ago

I like the idea of putting the server config in a separate folder, will update my PR :P, but I wouldn't use it in tests, mainly for port use, this can change once we add Confidence and have environment specific configs

AdriVanHoudt commented 9 years ago

Also something that I did was to have a default server and then instead of just passing full on manifests, only pass along what you want to change to the default on and then do Hoek.applyToDefaults And maybe put the config file in a config folder

hussainanjar commented 9 years ago

@AdriVanHoudt I agree with the idea of having manifest.json in config folder but I'm not sure about the idea of defaultServer.

One config file defining everything looks more neat and will be easily extendible if different connections are required for web and say API.

More readable too I think.

AdriVanHoudt commented 9 years ago

@hussainanjar those are the same thing right? Only I allow to override stuff and you don't

hussainanjar commented 9 years ago

@AdriVanHoudt why do you feel the need of defining default server outside of config file ?

hussainanjar commented 9 years ago

@AdriVanHoudt got it now while writing tests, your approach makes test simpler. :+1: