search

outmoded / university

Community learning experiment
Other
371 stars 193 forks source link

Assignment5 #146

Closed rutaihwa closed 9 years ago

rutaihwa commented 9 years ago

Assignement5, late submission :neutral_face:

136

AdriVanHoudt commented 9 years ago

LGTM, why is travis not running for this? @zoe-1 ?

zoe-1 commented 9 years ago

@AdriVanHoudt checking on it.

zoe-1 commented 9 years ago

@AdriVanHoudt See my last comment this post https://github.com/hapijs/university/issues/143 . I think that issue may relate to this one.

zoe-1 commented 9 years ago

@AdriVanHoudt It's OK now. @nlf fixed the hapijs/university travis issue. Just a restart that was needed. So, that fixes the university repo travis issue. I think @rutaihwa should trigger travis to re-run. His project should pass travis now.

There are merge conflicts with this project and the hapi u repo. So, it does not pass.

rutaihwa commented 9 years ago

Thanks @AdriVanHoudt and @zoe-1 , I have tried to restart travis and test runs but fails, that expected right? https://travis-ci.org/rutaihwa/hueniversity/jobs/65283840

zoe-1 commented 9 years ago

@rutaihwa your project is OK with travis. Since this is assignment5 and we moved on to assignment6. You are behind the head on the master branch. So, travis will not pass telling us there are merge conflicts. This means if we did want to merge your PR into master it would require us to resolve conflicts first.

We have already merged in the PR for assignment5 and moved on to assignment6 so please do not worry about this not passing. Have fun coding!

rutaihwa commented 9 years ago

Thanks @zoe-1 ! :+1: