Assignment1

[zoe-1]

@benleen Travis fails because you are getting below linting errors:

• hapi/no-shadow-relaxed - server is already declared in the upper scope.
• hapi/no-shadow-relaxed - next is already declared in the upper scope.

Make .eslintrc file in project root to fix shadow linting issues

.eslintrc file content below:

{
    "extends": "./node_modules/lab/lib/linters/eslint/.eslintrc",
    "rules": {
        // Override any settings from the "parent" configuration
        "hapi/no-shadow-relaxed": [1, { "ignore": ["err", "done", "server", "next", "res"] }],
    }
}

Above will make Travis hapi :-)

[zoe-1]

You are adding requirements from later assignments into assignment1. For example, you are using Glue in assignment1 but that was not added until assignment5. This is not a big deal as long as you are aware of it.

But, I would recommend working through the assignments step by step rather than merging requirements of various assignments together. But, if that is too simple for you, then make each assignment the way you seem fit. But, this may make it harder for us to provide code review etc.

To start at the proper place for assignment1 do the following:

• Fork the hapijs/university repository.
• git clone https://github.com/benleen/university.git
  • bring clone of your fork into local machine.
• git branch -a
  • This will display all remote branches associated with the repo.
  • note: git branch will not show remote branches only local. (add -a option to see remotes)
• git checkout assignment1
  • This will checkout the remote branch assignment1 which is the starting point for the assignment.
  • To work on later assignments, adjust assignment# value to checkout the appropriate starting point.
  • assignment# branches are the starting points for each assignment. For example, assignment1 branch is the starting point for assignment 1.
    To see assignment1 solution, checkout the next assignment. (assignment2).
• Next create a branch to work on assignment1 with.
  • Previous command git checkout assignment1 has you working on branch named: 'assignment1'
  • git status will show you are on branch assignment1 (no longer on master)
  • git checkout -b my_assignment1 Now, you have your own branch to work on assignment1 called: my_assignment1.
    Plus, you can step back to assignment1 starting point with: git checkout assignment1.
  • Write code fulfilling assignment1 requirements on branch my_assignment1.
  • periodically commit your assignments code to my_assignment1 branch.
    • git add .
    • git commit
• When ready push your assignment to your fork of hapijs / university:
  • git push origin my_assignment1
• Then, in github repo make PR request to merge the branch my_assignment1 into the university repo branch assignment1.
• If you want to see the completion of assignment1: git checkout assignment2.
  Cheers!

[zoe-1]

See comments here about configuring linting options for more details about shadow linting.

[ghost]

@zoe-1

• Should I care about Travis for assignment1? If I'm not mistaking it's even explicitly mentioned for assignment3. I can live with the red cross. ;)
• About the branches. That seems to be what I've done... I must be missing something. Branch in my fork of hapijs/university: https://github.com/benleen/university/tree/assignment1 from which my PR originates. Also... I don't seem to using "Glue" either.

[zoe-1]

@benleen I looked over your assignment a bit too quickly. Yes, you are right about the branches. I was looking at your master branch. Sorry. In respect to Travis, I would recommend getting travis to pass. But, since the original assignment did not require it, no worries if you do not.