request lifecycle term: "application level extension"

[zoe-1]

Currently, writing a lesson for hapi university.
The lesson is about the request lifecycle, hooks, and events. We are changing an extension that was "application level extension" to be a "request level" extension.

There are three types of request lifecycle extensions:

• application level / server level (server wide)
• plugin level
• route level See Matt Harrison's post here: https://stackoverflow.com/questions/37424079/how-to-apply-a-hapi-js-plugin-to-specific-routes

When extensions apply to all requests received by the server should we call them "application level" or "server level". Matt Harrison used the term "request level extension" so I want to call them "server level extensions" or "application level extensions". However, I think "server level extensions" is to close to server extension points: function(server, next).
So, I am going to call them "application level extensions"

Is everyone ok with that?

[zoe-1]

Assignment9 dev here

[devinivy]

Some initial feedback!

1. This is awesome. I think it's a great idea for an assignment.
2. Regarding "server-level" versus "application-level" extension, I think it's something to be really careful about. As you pointed out, there are both "server extensions" (e.g. onPreStart, onPostStop, etc.) and "request extensions" (e.g. onRequest, onPreHandler, etc.), so we probably wouldn't want to overload the term "server" here. At the same time, I think we also need to be careful with "application." The implication is that an "application extension" would apply to every request on the entire server. But really these extensions are added to whatever connections are selected by your server. To be explicit we might call these things "connection-level request extensions". Luckily server extensions don't have the same issue ;D
3. Despite everything I said above, perhaps if we're really explicit about the meaning of "application level extensions" then the terminology will be friendlier, especially for those who do not have multi-connection servers. Would be curious to get feedback from others.
4. I don't know about the term "request level"– they're definitely tied to routes, so I'd call them "route-level request extensions."

👏 thank you for working on this!!

[zoe-1]

Sorry. did not realize github tracks all amended commit references to issue too.

[zoe-1]

@devinivy re-wrote the two documents to reflect the terms you recommended. Documents listed below.

• assignment9
  • intro to the request lifecycle

In respect to the three levels of request lifecycle extensions, used:

• connection-level
• plugin-level
• route-level

[zoe-1]

https://github.com/hapijs/university/pull/254 This PR contains assignment9 written according to @devinivy recommendations in this issue.