search

outmoded / university

Community learning experiment
Other
371 stars 194 forks source link

Assignment #3 - 100% coverage #89

Closed hussainanjar closed 9 years ago

hussainanjar commented 9 years ago

Thanks to all whose PR are helping me do the assignments :+1:

closes #79

zoe-1 commented 9 years ago

@hussainanjar Your Makefile is broken so tests are failing. In the Makefile commands must be tabbed in and not spaced indentation.

hussainanjar commented 9 years ago

@zoe-1 thanks for the detailed review will work on fixing these :+1:

zoe-1 commented 9 years ago

@hussainanjar good work on the changes. :-)

However, if I review your lib/index.js in assignment3 branch at: https://github.com/hussainanjar/hueniversity/tree/assignment3 You still have Hoek variable assigned to required('hoek') but it is not used in the script.

hussainanjar commented 9 years ago

@zoe-1 for some reason I just couldn't see it, thanks for pointing out :+1: