search

overcastsoftware / wagtailcharts

Customisable Chart.js charts in Wagtail
MIT License
24 stars 3 forks source link

Use locale-aware number formatting #17

Closed RealOrangeOne closed 2 months ago

RealOrangeOne commented 3 months ago

This not only ensures the correct separator for the locale, but also removes a dependency

saevarom commented 3 months ago

This might pose a problem for small languages such as Icelandic, where people generally have their browsers in an English locale, but developers still want to present numbers in the user's locale. This is a good idea though, so perhaps we should expose a configuration value where the developer can specify the locale to use inIntl.NumberFormat

saevarom commented 2 months ago

I think we can both be happy with the way it is now @RealOrangeOne :)

saevarom commented 2 months ago

This has been released in version 0.6 on pypi