ovh / python-ovh

Thin wrapper around OVH's APIs. Handles all the hard work including credential creation and requests signing.
https://pypi.org/project/ovh/
Other
297 stars 81 forks source link

Add build dependency on python3-setuptool in debian packaging. #41

Closed jon-d closed 7 years ago

jon-d commented 7 years ago

The package python3-setuptool is missing to build the package on a Debian stable (jessie).

yadutaf commented 7 years ago

Thanks for your PR ! Looks good to me. But I did not do the packaging. @arnaudmorin can you confirm this is good to go ?

arnaudmorin commented 7 years ago

Sounds good to me!

yadutaf commented 7 years ago

Hi @jon-d,

I'm afraid there is one last step before I can merge. Can you sign your commit to acknowledge the CONTRIBUTING.rst guidelines ?

A command line this should do the trick :

git commit --amend -s --no-edit
git push --force
jon-d commented 7 years ago

Done. Thank you for integrating this :-)

yadutaf commented 7 years ago

Merged. Thanks for you contribution!