search

ovh / python-ovh

Thin wrapper around OVH's APIs. Handles all the hard work including credential creation and requests signing.
https://pypi.org/project/ovh/
Other
297 stars 81 forks source link

Add ResourceExpiredError exception #48

Closed achaussier closed 7 years ago

achaussier commented 7 years ago

Signed-off-by: Alexandre Chaussier alexandre.chaussier@temelio.com

Hello,

I begin to wrote some scripts to work with your API and I've had error last days about an expired service. To catch properly this case, I think a dedicated error can be useful.

Today, this service is not returned by the API so I don't have the return code, but I've found the toorop/ovh-cli/issues/1 issue and they catch the 460 code. I hope this have not changed.

geoffreybauduin commented 7 years ago

Hello, thank you for your contribution.

Before anything can happen, we need the Developer Certificate of Origin to be respected (see https://github.com/ovh/python-ovh/blob/master/CONTRIBUTING.rst) , hence I will ask you to amend your commit with the "Signed off" mention inside the commit message.

I believe a quick command like this one below will do the trick.

git commit -s --amend --no-edit && git push --force
achaussier commented 7 years ago

Hello,

"Signed off" mention added.