Closed 4383 closed 6 years ago
Can you review please?
@kryskool done!
Hello, As we are modifying setup.cfg, should we add wheel packaging to setup.cfg ? It will be compliant with new packaging methods of Python (cf https://pythonwheels.com/ )
Let's just add pip install wheel
and
[bdist_wheel]
universal = 1
[metadata]
license_file = LICENSE
What do you think ?
@Rbeuque74
Not necessary to add wheel package on setup.cfg, it's a developer feature
You can add it to the requirement-dev.txt
Regards
@Rbeuque74 Yep the @kryskool approach is right, just add the wheel
into requirement-dev.txt
resolve the problem.
But for more compatibility with my improvement I want to add wheel into the sub section dev
of the setup.cfg
Requirement added into the setup.cfg in the sub section extras_require
for the dev
target
Hello, in order to merge your PR, we require you to sign your commit (see https://github.com/ovh/python-ovh/blob/master/CONTRIBUTING.rst#contributing-to-python-ovh)
@geoffreybauduin commit signed
Hi @Rbeuque74 can you review please?
Hello @4383, Please check https://github.com/4383/python-ovh/pull/1, and if you are ok with it, we will release it :)
@Rbeuque74 bdist_wheel
added
https://github.com/4383/python-ovh/pull/1 was containing three changes regarding wheel, and you only backported 1 of them :( Two changes are: adding the bdist_wheel during the test procedure; adding the LICENSE file in the packaging so that it can be embed with the library.
I will add them on another PR then...
Hey!
Overview
Using
setup.cfg
to configure project packaging. functionality introduced by setuptools 30.3.0.Features
requirements*
managementBenefits
Have fun!