search

ovh / python-ovh

Thin wrapper around OVH's APIs. Handles all the hard work including credential creation and requests signing.
https://pypi.org/project/ovh/
Other
278 stars 76 forks source link

[FIX] Using or importing the ABCs from 'collections' instead of from … #98

Closed fmdl closed 2 years ago

fmdl commented 3 years ago

…'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working

fmdl commented 3 years ago

ping @rbeuque74

fmdl commented 3 years ago

@rbeuque74 can you explain what I will do excatly ?

Cajuteq commented 2 years ago

Hi, as original requester of #96 thank you for taking the time, Also I think @rbeuque74 is asking for a complete review and update of the calls to requests although I don't understand why because this fix is about collections. Also I tried to check which version of the dependencies are used and ended up without finding any requirements.txt and with pip show ovh showing no dependencies. Maybe documenting and updating dependencies could be the point of another merge request ? Leaving it to you guys, thanks again

rbeuque74 commented 2 years ago

Hello, Sorry for the delay.

Per #108, I removed the vendoring of requests. Hence, this problem is now gone.

Thanks for the report, Closing, per #108.