search

owncloud-archive / news

:newspaper: News app for ownCloud
GNU Affero General Public License v3.0
290 stars 106 forks source link

Error messages after adding broken feeds should be persistent #71

Open jancborchardt opened 11 years ago

jancborchardt commented 11 years ago

When importing my current feeds, 2 sites get the error: »Can not add feed: URL does not exist or has invalid xml«

http://visualidiot.com/ gets that, even though it has a feedburner feed and in the code <link rel="alternate" type="application/rss+xml" title="Visual Idiot's Wonderful RSS Feed" href="http://feeds.feedburner.com/visualidiot">

The same happens for http://blogs.gnome.org/mccann/ – adding that one on its own works perfectly though.

BernhardPosselt commented 11 years ago

As for visualidiot:

This page contains the following errors:

error on line 116 at column 35: StartTag: invalid element name
Below is a rendering of the page up to the first error.

As for the mccan: can not reproduce, can you post your opml?

BernhardPosselt commented 11 years ago

owncloud/apps#69 owncloud/apps#99

jancborchardt commented 11 years ago

Yup, my OPML:

<opml version="1.1"><!--Generated by NewsBlur - www.newsblur.com--><head><title>NewsBlur Feeds</title><dateCreated>2013-04-15 11:37:25.296792</dateCreated><dateModified>2013-04-15 11:37:25.296792</dateModified></head><body><outline htmlUrl="http://www.reddit.com/r/tldr/" text="&lt;div&gt;Too long; didn't read (TLDR or TL;DR)&lt;/div&gt;" title="&lt;div&gt;Too long; didn't read (TLDR or TL;DR)&lt;/div&gt;" type="rss" version="RSS" xmlUrl="http://www.reddit.com/r/tldr.rss" /><outline text="Design" title="Design"><outline htmlUrl="http://worrydream.com/" text="&lt;div&gt;Bret Victor's website&lt;/div&gt;" title="&lt;div&gt;Bret Victor's website&lt;/div&gt;" type="rss" version="RSS" xmlUrl="http://worrydream.com/feed.xml" /><outline htmlUrl="http://www.hylkebons.nl/journal/rss/" text="Journal - Hylke Bons" title="Journal - Hylke Bons" type="rss" version="RSS" xmlUrl="http://feeds.feedburner.com/HbonsHome" /><outline htmlUrl="http://afaikblog.wordpress.com" text="As far as I know" title="As far as I know" type="rss" version="RSS" xmlUrl="https://afaikblog.wordpress.com/feed/" /><outline htmlUrl="http://informationarchitects.net" text="Information Architects" title="Information Architects" type="rss" version="RSS" xmlUrl="http://informationarchitects.net/feed/" /><outline htmlUrl="http://ignorethecode.net" text="ignorethecode.net" title="ignorethecode.net" type="rss" version="RSS" xmlUrl="http://feeds.feedburner.com/IgnoreTheCode" /><outline htmlUrl="http://blogs.gnome.org/mccann" text="Push the Button" title="Push the Button" type="rss" version="RSS" xmlUrl="https://blogs.gnome.org/mccann/feed/" /><outline htmlUrl="http://littlebigdetails.com/" text="Little Big Details" title="Little Big Details" type="rss" version="RSS" xmlUrl="http://feeds.feedburner.com/littlebigdetails" /><outline htmlUrl="http://theixdlibrary.com" text="The IxD Library" title="The IxD Library" type="rss" version="RSS" xmlUrl="http://theixdlibrary.com/feed/" /><outline htmlUrl="http://52weeksofux.com/" text="52 Weeks of UX" title="52 Weeks of UX" type="rss" version="RSS" xmlUrl="http://feeds.feedburner.com/52WeeksOfUx" /><outline htmlUrl="http://blog.mengto.com" text="Meng To - UI/UX Designer" title="Meng To - UI/UX Designer" type="rss" version="RSS" xmlUrl="http://blog.mengto.com/feed/" /></outline><outline text="Nomadism" title="Nomadism"><outline htmlUrl="http://a-flat.posterous.com" text="a-flat" title="a-flat" type="rss" version="RSS" xmlUrl="http://a-flat.posterous.com/rss.xml" /><outline htmlUrl="http://egor.im" text="egor.im" title="egor.im" type="rss" version="RSS" xmlUrl="http://feeds.feedburner.com/egorim" /><outline htmlUrl="http://nomadbase.org/" text="nomadbase - find the others..." title="nomadbase - find the others..." type="rss" version="RSS" xmlUrl="http://nomadbase.org/rss.xml" /><outline htmlUrl="http://casarobino.org/frontpage" text="Casa Robino - Shared Hospitality" title="Casa Robino - Shared Hospitality" type="rss" version="RSS" xmlUrl="http://casarobino.org/rss.xml" /><outline htmlUrl="http://casabhavani.org" text="Casa Bhavani" title="Casa Bhavani" type="rss" version="RSS" xmlUrl="http://casabhavani.org/feed/" /></outline><outline htmlUrl="http://www.elezea.com" text="Elezea" title="Elezea" type="rss" version="RSS" xmlUrl="http://feeds.feedburner.com/elezea" /><outline htmlUrl="http://twitter.com/MozillaUX" text="Twitter / MozillaUX" title="Twitter / MozillaUX" type="rss" version="RSS" xmlUrl="http://api.twitter.com/1/statuses/user_timeline.rss?screen_name=mozillaux" /><outline htmlUrl="http://blog.mozilla.org/ux" text="Mozilla UX" title="Mozilla UX" type="rss" version="RSS" xmlUrl="http://blog.mozilla.org/ux/feed/" /><outline htmlUrl="http://planet.gnome.org/ux/" text="Planet UX" title="Planet UX" type="rss" version="RSS" xmlUrl="https://planet.gnome.org/ux/rss20.xml" /><outline htmlUrl="http://design.canonical.com" text="Design" title="Design" type="rss" version="RSS" xmlUrl="http://design.canonical.com/feed/" /><outline htmlUrl="https://make.wordpress.org/ui" text="Make WordPress UI" title="Make WordPress UI" type="rss" version="RSS" xmlUrl="https://make.wordpress.org/ui/feed/" /><outline htmlUrl="http://emptystat.es/" text="Empty States" title="Empty States" type="rss" version="RSS" xmlUrl="http://emptystat.es/rss" /><outline htmlUrl="http://visualidiot.com" text="Visual Idiot" title="Visual Idiot" type="rss" version="RSS" xmlUrl="http://feeds.feedburner.com/visualidiot" /><outline htmlUrl="http://www.picturesforsadchildren.com" text="pictures for sad children" title="pictures for sad children" type="rss" version="RSS" xmlUrl="http://www.rsspect.com/rss/pfsc.xml" /><outline htmlUrl="http://identity.mozilla.com/" text="Identity at Mozilla" title="Identity at Mozilla" type="rss" version="RSS" xmlUrl="http://identity.mozilla.com/rss" /></body></opml>

wavocedepigu commented 11 years ago

Related to https://github.com/owncloud/news/issues/212 ?

BernhardPosselt commented 11 years ago

Closed because this is not solvable.

jancborchardt commented 11 years ago

Why is it not a solution to add it, and when you select it have a notice in the content area »Bla bla not valid« and it gives you the direct address to the website?

BernhardPosselt commented 11 years ago

Because its a news reader and not a bookmark app. I dont think it has any value for you if it just adds the page.

Apart from that most user controls wont work and there wont be a consistent interface.

jancborchardt commented 11 years ago

And if you import your feeds and some of them just don’t work, they’ll just vanish? That’s not really nice. I don’t mean it as a bookmarks app but simply for being forgiving. (Although I would very much like Bookmarks and News to just merge into a Reader or Instapaper like app.)

BernhardPosselt commented 11 years ago

Yeah i mean we would have entries that would open a new tab when you click on them and that you cant distinguish from each other (iframe is an XSS risk).

That’s not really nice.

Yeah but if it does not work it does not work.

Apart from that the usecase and format of a news reader is very much different than from a bookmarks app and Im very much against merging the two apps.

BernhardPosselt commented 11 years ago

I mean for instance import: theres no way to merge opml and bookmarks, or take syncing for instance, it would be totally broken.

jancborchardt commented 11 years ago

No we wouldn’t have entries which would open a new tab, nor would we have iframes. That’s not what I said.

What I said is that for an erroneous feed, display that information in the content area. Like, a sad face feed icon or something, then »The feed of this site is broken :(« and then »Go to the website directly instead: http://yeeeeah.com«

Also, it could have an error icon as favicon.

On Tue, Aug 6, 2013 at 3:14 PM, Bernhard Posselt notifications@github.comwrote:

Yeah i mean we would have entries that would open a new tab when you click on them and that you cant distinguish from each other (iframe is an XSS risk).

That’s not really nice. Yeah but if it does not work it does not work.

— Reply to this email directly or view it on GitHubhttps://github.com/owncloud/news/issues/71#issuecomment-22177525 .

BernhardPosselt commented 11 years ago

I dont see why this should be useful.

BernhardPosselt commented 11 years ago

I mean if its broken, why should i want to go to the page? Also if its broken and its persistent it forces me to delete all entries by hand.

oparoz commented 9 years ago

And we need a button to edit the feed so that we can try and fix it.