search

owncloud-archive / news

:newspaper: News app for ownCloud
GNU Affero General Public License v3.0
290 stars 106 forks source link

Renaming title of news causes "Request forbidden" #903

Closed rakekniven closed 8 years ago

rakekniven commented 8 years ago

Just added feed. Want to rename it. After clicking edit, change title and hit the tick it tells me: "Request forbidden. Are you an admin?" bildschirmfoto 2016-01-03 um 20 36 03

ownCloud version: 8.2.2 news version: 6.1.1

Side note: Changing title using iOS news app with same user account works pretty well.

cosenal commented 8 years ago

I can reproduce it. @BernhardPosselt any idea?

BernhardPosselt commented 8 years ago

Can not reproduce this on master

rakekniven commented 8 years ago

Can I test master on ownCloud 8.2.2?

BernhardPosselt commented 8 years ago

yes

cosenal commented 8 years ago

@BernhardPosselt I know it's obvious, but I'll state it anyway: in order to reproduce it, you need to be logged in as a non-admin user.

BernhardPosselt commented 8 years ago

@cosenal m( will check

BernhardPosselt commented 8 years ago

Can reproduce it, will check :)

BernhardPosselt commented 8 years ago

@cosenal first suspision is a stupid typo here: https://github.com/owncloud/news/blob/master/controller/feedcontroller.php#L262 but does not look like it

Can you check if its the PATCH method that causes issues? As in change the method in the routes to PUT and modify the JS here? https://github.com/owncloud/news/blob/master/js/service/FeedResource.js#L337

rakekniven commented 8 years ago

Just checked against master. UI shows version 6.1.4 Now I can change title of feed, but the yellow message shown at screenshot of my first posting is still shown. And yes I am not an admin.

BernhardPosselt commented 8 years ago

Issue was that the patch method docblock started with /* instead of /\ at this line fyi: https://github.com/owncloud/news/blob/master/controller/feedcontroller.php#L261